Vered Volansky has uploaded a new change for review. Change subject: core: cleanup - removed unused methods ......................................................................
core: cleanup - removed unused methods Removed unused methods in StorageDomainCommandBase. Change-Id: I9e3b962c9fe747e493f2d8fb12ae8f27651ca0c4 Signed-off-by: Vered Volansky <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java 1 file changed, 0 insertions(+), 24 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/87/32287/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java index 8c7672f..752eb95 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java @@ -46,7 +46,6 @@ import org.ovirt.engine.core.dao.ImageStorageDomainMapDao; import org.ovirt.engine.core.dao.LunDAO; import org.ovirt.engine.core.dao.SnapshotDao; -import org.ovirt.engine.core.dao.StorageDomainOvfInfoDao; import org.ovirt.engine.core.dao.StorageServerConnectionDAO; import org.ovirt.engine.core.utils.ejb.BeanProxyType; import org.ovirt.engine.core.utils.ejb.BeanType; @@ -136,21 +135,6 @@ return returnValue; } - private boolean hasImages() { - int allowedDisksNum = getOvfInfo().size(); - return getDiskImageDao() - .getAllSnapshotsForStorageDomain(getStorageDomain().getId()) - .size() > allowedDisksNum - || getImageStorageDomainMapDao().getAllByStorageDomainId(getStorageDomain().getId()).size() > allowedDisksNum; - } - - public List<StorageDomainOvfInfo> getOvfInfo() { - if (ovfInfo == null) { - ovfInfo = getStorageDomainOvfInfoDao().getAllForDomain(getStorageDomain().getId()); - } - return ovfInfo; - } - private StoragePoolIsoMap getStoragePoolIsoMap() { return getStoragePoolIsoMapDAO() .get(new StoragePoolIsoMapId(getStorageDomain().getId(), @@ -178,10 +162,6 @@ protected boolean checkStorageDomain() { return isStorageDomainNotNull(getStorageDomain()); - } - - protected boolean checkStorageDomainInDb() { - return getStorageDomainStaticDAO().get(getStorageDomain().getId()) != null; } protected boolean checkStorageDomainStatus(final StorageDomainStatus... statuses) { @@ -464,10 +444,6 @@ protected ImageDao getImageDao() { return getDbFacade().getImageDao(); - } - - protected StorageDomainOvfInfoDao getStorageDomainOvfInfoDao() { - return getDbFacade().getStorageDomainOvfInfoDao(); } protected DiskImageDynamicDAO getDiskImageDynamicDAO() { -- To view, visit http://gerrit.ovirt.org/32287 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9e3b962c9fe747e493f2d8fb12ae8f27651ca0c4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
