Lior Vernia has posted comments on this change. Change subject: engine: support for adding network qos for rest-api ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/31868/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkQoSModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkQoSModel.java: Line 24: } Line 25: Line 26: @Override Line 27: public void executeSave() { Line 28: QosParametersBase<NetworkQoS> parameters = new QosParametersBase<NetworkQoS>(); > actually it is used. In RESTful api, I don't have the entity only the id. This is clearly only relevant for the remove command, so it could have a parameters class of its own (that doesn't need to inherit from QosParametersBase), or even maybe use IdParameters. Line 29: parameters.setQos(networkQoS); Line 30: Frontend.getInstance().runAction(VdcActionType.UpdateNetworkQoS, parameters, new IFrontendActionAsyncCallback() { Line 31: @Override Line 32: public void executed(FrontendActionAsyncResult result1) { -- To view, visit http://gerrit.ovirt.org/31868 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34f43f9edc10b7b52e096b2b6f1f43d19f129ed5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
