Gilad Chaplik has posted comments on this change. Change subject: engine: support for adding network qos for rest-api ......................................................................
Patch Set 4: (4 comments) http://gerrit.ovirt.org/#/c/31868/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkQoS.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkQoS.java: Line 98: Line 99: @Override Line 100: public boolean equals(Object o) { Line 101: return super.equals(o) && Line 102: o instanceof NetworkQoS && > The equals() implementation of QosBase already guarantees this is true. Done Line 103: equalValues((NetworkQoS) o); Line 104: } Line 105: Line 106: @Override http://gerrit.ovirt.org/#/c/31868/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/CpuQos.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/CpuQos.java: Line 25: Line 26: @Override Line 27: public boolean equals(Object obj) { Line 28: return super.equals(obj) && Line 29: obj instanceof CpuQos && > Same comment as in NetworkQos. Done Line 30: equalValues((CpuQos) obj); Line 31: } Line 32: Line 33: @Override http://gerrit.ovirt.org/#/c/31868/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/StorageQos.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/StorageQos.java: Line 88: Line 89: @Override Line 90: public boolean equals(Object obj) { Line 91: return super.equals(obj) && Line 92: obj instanceof StorageQos && > Same comment as in NetworkQos. Done Line 93: equalValues((StorageQos) obj); Line 94: } Line 95: Line 96: @Override http://gerrit.ovirt.org/#/c/31868/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkQoSModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkQoSModel.java: Line 24: } Line 25: Line 26: @Override Line 27: public void executeSave() { Line 28: QosParametersBase<NetworkQoS> parameters = new QosParametersBase<NetworkQoS>(); > I think the qosId member can be removed altogether from the QosParametersBa actually it is used. In RESTful api, I don't have the entity only the id. Line 29: parameters.setQos(networkQoS); Line 30: Frontend.getInstance().runAction(VdcActionType.UpdateNetworkQoS, parameters, new IFrontendActionAsyncCallback() { Line 31: @Override Line 32: public void executed(FrontendActionAsyncResult result1) { -- To view, visit http://gerrit.ovirt.org/31868 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34f43f9edc10b7b52e096b2b6f1f43d19f129ed5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
