Liron Aravot has posted comments on this change. Change subject: core: create OVF store as non shareable on gluster domain ......................................................................
Patch Set 1: (2 comments) Maor, ovf stores are shareable so that you'll be able to backup that data contained on it using multiple vms. the corner case of gluster storage domain shouldn't affect imo the other usecases in which it'll be useful to have those as shareable disks. http://gerrit.ovirt.org/#/c/32034/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-08-27 15:14:42 +0300 Line 6: Line 7: core: create OVF store as non shareable on gluster domain Line 8: Line 9: Ovirt doesn't support the creation of shareable disks on gluster > Please remove extra space "Ovirt " to "Ovirt " Done Line 10: storage domains. Therefore the OVF store disks on gluster domains should Line 11: be created as non shareable. Line 12: Line 13: Change-Id: I8e5d05a80061b963d61e09919824830b3624d3e6 http://gerrit.ovirt.org/#/c/32034/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateOvfVolumeForStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateOvfVolumeForStorageDomainCommand.java: Line 68: getReturnValue().getInternalVdsmTaskIdList().addAll(vdcReturnValueBase.getInternalVdsmTaskIdList()); Line 69: setSucceeded(true); Line 70: } Line 71: Line 72: private boolean shouldOvfStoreBeShareable() { > /s/shouldOvfStoreBeShareable/isShareableOvfStore I find the current name more readable Line 73: return getStorageDomain().getStorageType() != StorageType.GLUSTERFS; Line 74: } Line 75: Line 76: public DiskImage createDisk(Guid domainId) { -- To view, visit http://gerrit.ovirt.org/32034 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e5d05a80061b963d61e09919824830b3624d3e6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
