Yair Zaslavsky has posted comments on this change. Change subject: aaa: Engine should start even if exception occured in load of legacy provider ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/29879/4/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/Utils.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/Utils.java: Line 66: } Line 67: conf.setProperty("config.LdapServers", StringUtils.join(ldapServers, ";")); Line 68: } catch (Exception ex) { Line 69: // If refresh fails, an attempt to refresh should be made on the next time there is an attempt to Line 70: // query for ldap entries from the domain > please log exception? Done Line 71: } Line 72: } Line 73: Line 74: private static void putIfAbsent(Properties props, String key, String value) { http://gerrit.ovirt.org/#/c/29879/4/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/utils/dns/DnsSRVLocator.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/utils/dns/DnsSRVLocator.java: Line 400: return results; Line 401: } Line 402: Line 403: public URI constructURI(String protocol, String address, String defaultLdapSeverPort) throws URISyntaxException { Line 404: address = address.indexOf("://") != -1 ? address.substring(address.indexOf("://") + 3) : address; > how come this appear now? I mean, how has it worked so for? i am reusing constructURI now in more than one place, this is why it worked before. At past I have used it only at startup, where I took the list of hostnames that serrve as ldap servers. Now , I use this during the search as well. Line 405: String[] parts = address.split("\\:"); Line 406: String hostname = address; Line 407: String port = defaultLdapSeverPort; Line 408: if (parts.length == 2) { -- To view, visit http://gerrit.ovirt.org/29879 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ba595253c2569cf581e690b68348e6ae1c804b1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
