Alon Bar-Lev has posted comments on this change. Change subject: aaa: Engine should start even if exception occured in load of legacy provider ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29879/1/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/extensionsmgr/EngineExtensionsManager.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/extensionsmgr/EngineExtensionsManager.java: Line 194: Config.getValue(ConfigValues.MaxLDAPQueryPartsNumber).toString()); Line 195: attachConfigValuesFromDb(dirConfig, domain); Line 196: load(dirConfig); Line 197: } catch (Exception ex) { Line 198: log.error("An error has occurred while initializaing a kerberos/ldap extension. Exception message is: {}", ex.getMessage()); > And another question - how many retries will each extension have ? for now I keep it simple, every time the extension is called and is not initialized it should initialize it-self. it can have some duration in which it won't try... I did not think this is needed, as for example, if ldap is down after initialization we fail the same way... the initialization access to ldap is just optimization, to have a connection set before application starts to serve users. for the first question... there is no reason to add complexity of adding a thread that tries to initialize extensions if failed... this, if required should be done by extension. Line 199: log.debug("", ex); Line 200: } Line 201: } Line 202: } -- To view, visit http://gerrit.ovirt.org/29879 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ba595253c2569cf581e690b68348e6ae1c804b1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
