Alon Bar-Lev has posted comments on this change. Change subject: aaa: Associate users only with managed groups by oVirt ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/31757/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/DirectoryUtils.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/DirectoryUtils.java: Line 25: Line 26: public class DirectoryUtils { Line 27: Line 28: public static DbUser mapPrincipalRecordToDbUser(String authz, ExtMap principal) { Line 29: flatGroups(principal); > Do you think there is a scenario which is relevant here? I do not like modifying the parameter and then breaking some future code... that will be surprised that the entity changed, or add BIG FAT comment that we are changing it. Line 30: DbUser dbUser = DbFacade.getInstance().getDbUserDao().getByExternalId(authz, principal.<String>get(PrincipalRecord.ID)); Line 31: Guid userId = dbUser != null ? dbUser.getId() : Guid.newGuid(); Line 32: dbUser = new DbUser(mapPrincipalRecordToDirectoryUser(authz, principal)); Line 33: dbUser.setId(userId); -- To view, visit http://gerrit.ovirt.org/31757 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a5daf3c68cc04ebd4ad0ec6cfdfd6cf16ececb9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
