Alon Bar-Lev has posted comments on this change. Change subject: aaa: Associate users only with managed groups by oVirt ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/31757/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SyncUsers.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SyncUsers.java: Line 54 Line 55 Line 56 Line 57 Line 58 > once again, why run the mapPrincpalRecord.... method twice? maybe you comme ok, sorry, I did not understand your previous comment... it is not twice is that I am blind and you have two references to dbUser as there is no keyed list in java (a list of objects that has key within). -- To view, visit http://gerrit.ovirt.org/31757 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a5daf3c68cc04ebd4ad0ec6cfdfd6cf16ececb9 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
