Gilad Chaplik has posted comments on this change.

Change subject: frontend: add disk profile to disk flow
......................................................................


Patch Set 12:

(1 comment)

thanks derez :-)

http://gerrit.ovirt.org/#/c/29813/12/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java:

Line 213:                             
diskModel.getDiskProfile().setSelectedItem(diskProfile);
Line 214:                         }
Line 215:                     }
Line 216:                 }
Line 217:                 // inner model disk profiles
> formatter/move into 'else' branch
it's formatted, even changed it and formatted, and it went back :-)
Line 218:             } else {
Line 219:                 DiskProfile selectedDiskProfile = null;
Line 220:                 if (diskProfiles.getSelectedItem() != null) {
Line 221:                     selectedDiskProfile = 
diskProfiles.getSelectedItem();


-- 
To view, visit http://gerrit.ovirt.org/29813
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I30047ddcb6364660df6c62355f5f48526859b2fc
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to