Gilad Chaplik has posted comments on this change. Change subject: frontend: add disk profile to disk flow ......................................................................
Patch Set 6: (3 comments) new patch to follow http://gerrit.ovirt.org/#/c/29813/6//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-07-08 11:32:06 +0300 Line 4: Commit: Gilad Chaplik <gchap...@redhat.com> Line 5: CommitDate: 2014-08-10 14:54:04 +0300 Line 6: Line 7: frontend: add disk profile to disk flow > please elaborate on the change Done Line 8: Line 9: Change-Id: I30047ddcb6364660df6c62355f5f48526859b2fc http://gerrit.ovirt.org/#/c/29813/6/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java: Line 190: new AsyncQuery(new INewAsyncCallback() { Line 191: Line 192: @Override Line 193: public void onSuccess(Object model, Object returnValue) { Line 194: List<DiskProfile> list = > this section is way too hard to read :) can you please format/extract to me Done Line 195: (List<DiskProfile>) ((VdcQueryReturnValue) returnValue).getReturnValue(); Line 196: if (list != null) { Line 197: if (isItem == null) { Line 198: for (DiskModel diskModel : DisksAllocationModel.this.getDisks()) { http://gerrit.ovirt.org/#/c/29813/6/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java: Line 594: new AsyncQuery(this, Line 595: new INewAsyncCallback() { Line 596: @Override Line 597: public void onSuccess(Object innerModel, Object innerReturnValue) { Line 598: List<DiskProfile> diskProfiles = > same (extract/format/comments/etc) Done Line 599: ((VdcQueryReturnValue) innerReturnValue).getReturnValue(); Line 600: if (diskProfiles != null && !diskProfiles.isEmpty()) { Line 601: getDiskProfile().setItems(diskProfiles); Line 602: } -- To view, visit http://gerrit.ovirt.org/29813 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30047ddcb6364660df6c62355f5f48526859b2fc Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
