Omer Frenkel has posted comments on this change. Change subject: core: Graphics Device CRUD ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/25409/9/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/GraphicsDevice.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/GraphicsDevice.java: Line 46: dev.setId(vmDev.getId()); Line 47: return dev; Line 48: } Line 49: Line 50: } > Well, the GraphicsType enum determines type of graphics framebuffer. This e im ok with the new type enum, i just thought it might be handy to have a getter method that return this type in this class, because it may be usefull later, once you have this class, you can do getGraphicsType and get spice/vnc, its not a must -- To view, visit http://gerrit.ovirt.org/25409 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9eed1ddb4aa8e8376ba5eff662f1bdf49fda800 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
