Frank Kobzik has posted comments on this change. Change subject: core: Graphics Device CRUD ......................................................................
Patch Set 9: (2 comments) http://gerrit.ovirt.org/#/c/25409/9/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/GraphicsDevice.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/GraphicsDevice.java: Line 13: static { Line 14: typeToId = new HashMap<VmDeviceType, Guid>(); Line 15: typeToId.put(VmDeviceType.SPICE, Guid.createGuidFromString("00000000-0000-0000-0000-000000000000")); // $NON-NLS-1$ Line 16: typeToId.put(VmDeviceType.VNC, Guid.createGuidFromString("00000000-0000-0000-0000-000000000001")); // $NON-NLS-1$ Line 17: } > please use new guid instead of this Ok. Line 18: Line 19: Line 20: private GraphicsDevice() { } Line 21: Line 46: dev.setId(vmDev.getId()); Line 47: return dev; Line 48: } Line 49: Line 50: } > isn't it weird that there is no method that returns the GraphicsType ? its Well, the GraphicsType enum determines type of graphics framebuffer. This enum is used by 'upper layers' to bear the information about VM/template/whatever graphics framebuffer (VM add/update/run/.. commands, SetVmTicket command). In theory we could use VmDeviceType instead, but I don't think that's wise (GraphicsType is more restrictive nad has only SPICE/VNC values - otherwise you could create VM with graphics framebuffer AC97, let's say :) ). Or were you getting at something else? -- To view, visit http://gerrit.ovirt.org/25409 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9eed1ddb4aa8e8376ba5eff662f1bdf49fda800 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
