Oved Ourfali has posted comments on this change. Change subject: core: Suppress VdsNotResponding execution if fencing is disabled ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/31257/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java: Line 81: return true; Line 82: } Line 83: Line 84: // fencing will be executed Line 85: return false; > 1) It seems for me more readable I'm okay with both. I can add another option, add a boolean return value, and return it at the end of the method. adding some else statements, or if returnVal && isConnec.. etc.... Line 86: } Line 87: Line 88: /** Line 89: * Only fence the host if the VDS is down, otherwise it might have gone back up until this command was executed. If -- To view, visit http://gerrit.ovirt.org/31257 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I784564e41c89b4a95eff3377cd6545cf907ecdce Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
