Martin Peřina has posted comments on this change. Change subject: core: Suppress VdsNotResponding execution if fencing is disabled ......................................................................
Patch Set 3: (7 comments) http://gerrit.ovirt.org/#/c/31257/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java: Line 79: si > si => is Done Line 81: return true; Line 82: } Line 83: Line 84: // fencing will be executed Line 85: return false; > why not simply instead all 4 lines above : 1) It seems for me more readable 2) When we will need to add another check, we can do this without too much line changes Line 86: } Line 87: Line 88: /** Line 89: * Only fence the host if the VDS is down, otherwise it might have gone back up until this command was executed. If http://gerrit.ovirt.org/#/c/31257/3/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 124: VDS_TRY_CREATE_SECURE_CERTIFICATE_NOT_FOUND=Cannot add new Host using a secured connection, Certificate file could not be found. Line 125: VDS_FENCE_DISABLED=Cannot fence Host, Host fence is disabled. Line 126: VDS_FENCE_DISABLED_AT_SYSTEM_STARTUP_INTERVAL=Fence is disabled due to the Engine Service start up sequence. Line 127: VDS_FENCE_DISABLED_AT_QUIET_TIME=Another Power Management operation is still running, please retry in ${seconds} Sec. Line 128: VDS_FENCE_DISABLED_BY_CLUSTER_POLICY=Host ${VdsName} became Non Responsive and was not restarted due to disabled fencing in Fencing Policy of the Cluster. > in Fencing Policy of the Cluster => in Cluster Fencing Policy Done Line 129: TEMPLATE_IMAGE_NOT_EXIST=Cannot ${action} ${type}. Template's image doesn't exist. Line 130: VM_CANNOT_REMOVE_VDS_GROUP_VMS_DETECTED=Cannot ${action} ${type}. One or more VMs are still assigned to the Cluster Line 131: VMT_CANNOT_REMOVE_VDS_GROUP_VMTS_DETECTED=Cannot ${action} ${type}. One or more Template(s) are still associated with it Line 132: VDS_GROUP_CANNOT_REMOVE_HAS_VM_POOLS=Cannot ${action} ${type}.One or more VM-Pools are still associated with it http://gerrit.ovirt.org/#/c/31257/3/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties: Line 618: VDS_ALERT_PM_HEALTH_CHECK_FAILED_FOR_CON_SECONDARY_AGENT=Health check failed on Host ${VdsName} secondary concurrent agent, future fence operations may fail on this Host. Line 619: VDS_ALERT_FENCE_OPERATION_SKIPPED_BROKEN_CONNECTIVITY=Host ${VdsName} became non responsive and was not restarted due to Fencing Policy: ${Percents} percents of the Hosts in the Cluster have connectivity issues. Line 620: VDS_ALERT_PM_HEALTH_CHECK_FAILED_FOR_SEQ_SECONDARY_AGENT=Health check failed on Host ${VdsName} secondary sequential agent, future fence operations may fail is primary agent if not defined properly. Line 621: VDS_ALERT_NOT_RESTARTED_DUE_TO_POLICY=Host ${VdsName} became non responsive and was not restarted due to the Cluster Fencing Policy. Line 622: VDS_ALERT_FENCE_DISABLED_BY_CLUSTER_POLICY=Host ${VdsName} became Non Responsive and was not restarted due to disabled fencing in Fencing Policy of the Cluster. > s/in fencing policy of the cluster/in the Cluster Fencing Policy Done Line 623: VDS_HOST_NOT_RESPONDING_CONNECTING=Host ${VdsName} is not responding. It will stay in Connecting state for a grace period of ${Seconds} seconds and after that an attempt to fence the host will be issued. Line 624: TASK_STOPPING_ASYNC_TASK=Stopping async task ${CommandName} that started at ${Date} Line 625: REFRESH_REPOSITORY_IMAGE_LIST_FAILED=Refresh image list failed for domain(s): ${imageDomains}. Please check domain activity. Line 626: REFRESH_REPOSITORY_IMAGE_LIST_SUCCEEDED=Refresh image list succeeded for domain(s): ${imageDomains} http://gerrit.ovirt.org/#/c/31257/3/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java: Line 315: Line 316: @DefaultStringValue(" Power Management operation ${operation} is still running, please retry in ${seconds} Sec.") Line 317: String VDS_FENCE_DISABLED_AT_QUIET_TIME(); Line 318: Line 319: @DefaultStringValue("Host ${VdsName} became Non Responsive and was not restarted due to disabled fencing in Fencing Policy of the Cluster.") > same here ... Done Line 320: String VDS_FENCE_DISABLED_BY_CLUSTER_POLICY(); Line 321: Line 322: @DefaultStringValue("Cannot ${action} ${type}. Template's image doesn't exist.") Line 323: String TEMPLATE_IMAGE_NOT_EXIST(); http://gerrit.ovirt.org/#/c/31257/3/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties File frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties: Line 109: VDS_TRY_CREATE_SECURE_CERTIFICATE_NOT_FOUND=Cannot add new Host using a secured connection, Certificate file could not be found. Line 110: VDS_FENCE_DISABLED=Cannot fence Host, Host fence is disabled. Line 111: VDS_FENCE_DISABLED_AT_SYSTEM_STARTUP_INTERVAL=Fence is disabled due to the Engine Service start up sequence. Line 112: VDS_FENCE_DISABLED_AT_QUIET_TIME=Another Power Management operation is still running, please retry in ${seconds} Sec. Line 113: VDS_FENCE_DISABLED_BY_CLUSTER_POLICY=Host ${VdsName} became Non Responsive and was not restarted due to disabled fencing in Fencing Policy of the Cluster. > same Done Line 114: TEMPLATE_IMAGE_NOT_EXIST=Cannot ${action} ${type}. Template's image doesn't exist. Line 115: VM_CANNOT_REMOVE_VDS_GROUP_VMS_DETECTED=Cannot ${action} ${type}. One or more VMs are still assigned to the Cluster Line 116: VMT_CANNOT_REMOVE_VDS_GROUP_VMTS_DETECTED=Cannot ${action} ${type}. One or more Template(s) are still associated with it Line 117: VDS_GROUP_CANNOT_REMOVE_HAS_VM_POOLS=Cannot ${action} ${type}.One or more VM-Pools are still associated with it http://gerrit.ovirt.org/#/c/31257/3/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties File frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties: Line 123: VDS_TRY_CREATE_SECURE_CERTIFICATE_NOT_FOUND=Cannot add new Host using a secured connection, Certificate file could not be found. Line 124: VDS_FENCE_DISABLED=Cannot fence Host, Host fence is disabled. Line 125: VDS_FENCE_DISABLED_AT_SYSTEM_STARTUP_INTERVAL=Fence is disabled due to the Engine Service start up sequence. Line 126: VDS_FENCE_DISABLED_AT_QUIET_TIME=Another Power Management operation is still running, please retry in ${seconds} Sec. Line 127: VDS_FENCE_DISABLED_BY_CLUSTER_POLICY=Host ${VdsName} became Non Responsive and was not restarted due to disabled fencing in Fencing Policy of the Cluster. > same Done Line 128: TEMPLATE_IMAGE_NOT_EXIST=Cannot ${action} ${type}. Template's image doesn't exist. Line 129: VM_CANNOT_REMOVE_VDS_GROUP_VMS_DETECTED=Cannot ${action} ${type}. One or more VMs are still assigned to the Cluster Line 130: VMT_CANNOT_REMOVE_VDS_GROUP_VMTS_DETECTED=Cannot ${action} ${type}. One or more Template(s) are still associated with it Line 131: VDS_GROUP_CANNOT_REMOVE_HAS_VM_POOLS=Cannot ${action} ${type}.One or more VM-Pools are still associated with it -- To view, visit http://gerrit.ovirt.org/31257 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I784564e41c89b4a95eff3377cd6545cf907ecdce Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
