Oved Ourfali has posted comments on this change. Change subject: core: Skip fencing if host has connectivity issues ......................................................................
Patch Set 14: Code-Review-1 (1 comment) Fixing stuff when you're kids are around is a bad idea ;-) http://gerrit.ovirt.org/#/c/31303/14/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/FencingPolicy.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/FencingPolicy.java: Line 26: } else { Line 27: skipFencingIfSDActive = fencingPolicy.skipFencingIfSDActive; Line 28: skipFencingIfConnectivityBroken = fencingPolicy.skipFencingIfConnectivityBroken; Line 29: hostsWithBrokenConnectivityThreshold = fencingPolicy.hostsWithBrokenConnectivityThreshold; Line 30: hostsWithBrokenConnectivityThreshold = 50; why is this one here? I understand 50 is the default, but here you set it twice, once from the policy, and once to 50, so obviously it is wrong. It should be part of the other constructor. Line 31: } Line 32: } Line 33: Line 34: public boolean isSkipFencingIfSDActive() { -- To view, visit http://gerrit.ovirt.org/31303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a9c7db43b50421414ce9596137767b00cbfc2ae Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
