Martin Peřina has posted comments on this change. Change subject: core: Skip fencing if host has connectivity issues ......................................................................
Patch Set 13: (1 comment) http://gerrit.ovirt.org/#/c/31303/13/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/FencingPolicy.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/FencingPolicy.java: Line 11: * Skip fencing of host of it's connected to at least one storage domain. Line 12: */ Line 13: private boolean skipFencingIfSDActive; Line 14: private boolean skipFencingIfConnectivityBroken; Line 15: private int hostsWithBrokenConnectivityThreshold=50; Please move this to constructor, because FencingPolicy is compiled to JavaScript and there were problems with out-of-constructor field initialization. And please add spaces before and after '=' Line 16: Line 17: public FencingPolicy() { Line 18: skipFencingIfSDActive = false; Line 19: skipFencingIfConnectivityBroken = false; -- To view, visit http://gerrit.ovirt.org/31303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a9c7db43b50421414ce9596137767b00cbfc2ae Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
