Moti Asayag has posted comments on this change. Change subject: core: Set action and type when HotPlugUnplugVmNic fails ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugUnplugVmNicCommand.java Line 75: addCanDoActionMessage(VdcBllMessages.VAR__TYPE__INTERFACE); I agree with Einav comment. Unlike disk plug actions (which is separated into two different commands- plug and unplug), this command unites two actions and we should observe the parameter to find the requested action type. -- To view, visit http://gerrit.ovirt.org/6249 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01a6f954e3ebe86aeeb86410ff8a29760f1543e5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
