Einav Cohen has posted comments on this change.
Change subject: core: Set action and type when HotPlugUnplugVmNic fails
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugUnplugVmNicCommand.java
Line 75: addCanDoActionMessage(VdcBllMessages.VAR__TYPE__INTERFACE);
It seems that the HotPlugUnplugVmNic Command is being used for both Plug
("Activate") and UnPlug ("Deactivate") actions.
Therefore, I think that the ActionMessageParameters should be set according to
the "Action" property within the HotPlugUnplugVmNicParameters class:
If getAction() is PlugAction.PLUG, then the CanDoActionMessages array-list
should be added the "VAR__ACTION__ACTIVATE" message ("activate").
If getAction() is PlugAction.UNPLUG, then the CanDoActionMessages array-list
should be added the "VAR__ACTION__DEACTIVATE" message ("deactivate").
[worth consulting with an engine-core maintainer about this]
--
To view, visit http://gerrit.ovirt.org/6249
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I01a6f954e3ebe86aeeb86410ff8a29760f1543e5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
