Maor Lipchuk has posted comments on this change. Change subject: core: Prepare RemoveSnapshotCommand for testing ......................................................................
Patch Set 5: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java Line 124: getVmDAO().get(getVmId()); I believe the code line can be removed. Line 162: addCanDoActionMessage(VdcBllMessages.VAR__ACTION__REMOVE); You can use the protected method setActionMessageParameters() instead, and remove all the calls to this method from the canDoAction -- To view, visit http://gerrit.ovirt.org/6118 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e935b4324bba1b0cd2b501bfcd8738f1302cea1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
