Allon Mureinik has posted comments on this change. Change subject: core: Prepare RemoveSnapshotCommand for testing ......................................................................
Patch Set 3: (5 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java Line 127: Agreed - will fix. Line 163: PerformImagesChecks will be handled in a separate patch - see http://gerrit.ovirt.org/#/c/6197/ Line 177: disagree. The point of having this instance is to separate snapshot validation logic to a separate place, that can be easily mocked/separated/tested. Having everything in static methods will be counter-productive from that point of view. What I'd really like in a decent dependency-injection framework for commands so I don't have to create such instances myself. Line 206: The parent is VmCommand, which has nothing to do with snapshots - don't think this will be appropriate. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java Line 518: The only place is RestoreAllSnapshotsCommand - will do. -- To view, visit http://gerrit.ovirt.org/6118 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e935b4324bba1b0cd2b501bfcd8738f1302cea1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
