Maor Lipchuk has posted comments on this change. Change subject: core: Allow remove snapshot w/o disks (#825809) ......................................................................
Patch Set 5: +2 on the logic. Just minor suggestion, you can replace the validation for hasImages() at each image validation by calling it as part of the canDoAction validation (like so hasImages() && !validateImageNotInTemplate(). or just do a 'canoncial if' for images instead validate it at each method. -- To view, visit http://gerrit.ovirt.org/6119 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie65a93e75419b8b63e6c7e46fd9137f3db7684c4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
