Liron Aravot has posted comments on this change. Change subject: core: Allow remove snapshot w/o disks (#825809) ......................................................................
Patch Set 2: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java Line 43: I think that it's necessary to mention in a comment or with method name that this method performs lazy loading so that users of it would be aware that it's not just a simple getter and if they can would avoid using it to prevent DB access unless they really need it. Line 57: I'd put that in a separate method but that's just optional. -- To view, visit http://gerrit.ovirt.org/6119 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie65a93e75419b8b63e6c7e46fd9137f3db7684c4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
