Vered Volansky has posted comments on this change. Change subject: core: Add memory allocation check to hibernate VM ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/30883/8/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HibernateVmCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HibernateVmCommandTest.java: Line 98: Line 99: @Test Line 100: public void validateThreshold() { Line 101: doReturn(ValidationResult.VALID).when(storageDomainValidator).isDomainWithinThresholds(); Line 102: assertTrue(command.validateDomainWithinThresholds()); > Well... not exactly, will handle soon. OK, so this can't be done the way you suggested since the return value is bool and not ValidationResult. I changed to assertThat ... is(true) and is(false) for the next test. Check out the latest patchset. Line 103: } Line 104: Line 105: @Test Line 106: public void validateSpaceNotWithinThreshold() throws Exception { -- To view, visit http://gerrit.ovirt.org/30883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1250e6ea8d67f8026d66cf06589538343d39756a Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
