Allon Mureinik has posted comments on this change. Change subject: core: Add memory allocation check to hibernate VM ......................................................................
Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/30883/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java: Line 741: } Line 742: Line 743: private static void updateDisksStorageType(StorageType storageType, List<DiskImage> disksList) { Line 744: VolumeType volumeType = storageType.isFileDomain() ? VolumeType.Sparse : VolumeType.Preallocated; Line 745: //Only memory disk, which is added first, should be modified. > disksList contains memory and metadata images dummies, in this order. But why not pass just the memory disk to the handler? Line 746: disksList.get(0).setVolumeType(volumeType); Line 747: } Line 748: Line 749: protected static boolean doesStorageDomainHaveSpaceForRequest(StorageDomain storageDomain, List<DiskImage> disksList) { Line 745: //Only memory disk, which is added first, should be modified. Line 746: disksList.get(0).setVolumeType(volumeType); Line 747: } Line 748: Line 749: protected static boolean doesStorageDomainHaveSpaceForRequest(StorageDomain storageDomain, List<DiskImage> disksList) { > And do what with it? public method returns storage domain, can't add this t basa :-( Line 750: // not calling validate in order not to add the messages per domain Line 751: return (new StorageDomainValidator(storageDomain).hasSpaceForClonedDisks(disksList)).isValid(); Line 752: } Line 753: -- To view, visit http://gerrit.ovirt.org/30883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1250e6ea8d67f8026d66cf06589538343d39756a Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
