Yair Zaslavsky has posted comments on this change. Change subject: restapi : Create user API fails in REST & Java ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/31226/2/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendGroupsResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendGroupsResource.java: Line 211: return null; Line 212: } Line 213: Line 214: @Override Line 215: protected SearchParameters createSearchParameters(SearchType searchType, String constraint) { > no... to return DirectorySearchParameters instead of SearchParameters please read the "long scroll" attached :) I think you reviewed in the middle of me typing the 20 minutes++ scroll :) Line 216: if (SearchType.DirectoryGroup.equals(searchType)) { Line 217: return new DirectorySearchParameters(constraint, searchType); Line 218: } Line 219: return super.createSearchParameters(searchType, constraint); -- To view, visit http://gerrit.ovirt.org/31226 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifed7f39b5b706482198afd74163791105b1d956a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
