Yair Zaslavsky has posted comments on this change. Change subject: restapi : Create user API fails in REST & Java ......................................................................
Patch Set 2: Hi Alon, I'm pretty sure I expressed my reservation from changing AdSyntaxChecker (and all the other related search code) and suggested usage of the DirectorySearchParameters. Ravi mentioned the patch were this was introduced, I thought we are fine with that (indeed, at first I wanted to change the "search syntax") but it IMHO it was too complex. If you would like to fix this, IMHO we should change the search pattern from: ADGROUP@authz:constraint to : ADGROUP@authz:namespace:constraint for example: adgr...@acme.com:namespace:allnames=* (See BackendDomainGroupsResource.getSearchPattern for reference , BackendGroupsResource.java) Hmm, now I see that there is code duplication there of the search pattern... Should be fixed as well. Then if we go with this approach we should fix UI accordingly, and of course "revert the existence" of DirectorySearchParameters. Similar fix should be appllied to AdElementListModel.java and also to to relevant tests in bll and rest-api (and of course, impelemented for users as well, not just groups). Thoughts? -- To view, visit http://gerrit.ovirt.org/31226 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifed7f39b5b706482198afd74163791105b1d956a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
