Gilad Chaplik has posted comments on this change. Change subject: core: add disk profile to disk's commands ......................................................................
Patch Set 13: (2 comments) http://gerrit.ovirt.org/#/c/29038/13/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java: Line 624: Line 625: protected boolean setAndValidateDiskProfiles() { Line 626: if (getDisksList() != null) { Line 627: Map<DiskImage, Guid> map = new HashMap<>(); Line 628: for (DiskImage diskImage : getDisksList()) { > that will happen by default, we're handling disks and not snapshots. removing.. Line 629: map.put(diskImage, diskImage.getStorageIds().get(0)); Line 630: } Line 631: return validate(DiskProfileHelper.setAndValidateDiskProfiles(map)); Line 632: } http://gerrit.ovirt.org/#/c/29038/13/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java: Line 157: && getVmDynamicDao().get(getVmId()).getStatus() == VMStatus.Paused; Line 158: ExecutionHandler.endJob(executionContext, runAndPausedSucceeded); Line 159: } Line 160: Line 161: protected boolean setAndValidateDiskProfiles() { > you'd like to have qos defined for run once state. not needed. removing. Line 162: if (isRunAsStateless() && getVm().getDiskList() != null) { Line 163: Map<DiskImage, Guid> map = new HashMap<>(); Line 164: for (DiskImage diskImage : getVm().getDiskList()) { Line 165: map.put(diskImage, diskImage.getStorageIds().get(0)); -- To view, visit http://gerrit.ovirt.org/29038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7b6d977243cffc0bde772665ebaca47340075c6 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
