Liron Aravot has posted comments on this change. Change subject: core: add disk profile to disk's commands ......................................................................
Patch Set 15: (3 comments) http://gerrit.ovirt.org/#/c/29038/15/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java: Line 329: getParameters().setVolumeType(getDiskImage().getVolumeType()); Line 330: getParameters().setCopyVolumeType(CopyVolumeType.SharedVol); Line 331: getParameters().setParentCommand(getActionType()); Line 332: getParameters().setParentParameters(getParameters()); Line 333: getParameters().setDiskProfileId(getImage().getDiskProfileId()); why it's needed? Line 334: } Line 335: Line 336: /** Line 337: * The following method will determine if a provided vm/template exists http://gerrit.ovirt.org/#/c/29038/15/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java: Line 387: DiskImage oldDisk = (DiskImage) getOldDisk(); Line 388: if (!Objects.equals(oldDisk.getDiskProfileId(), diskImage.getDiskProfileId())) { Line 389: getImageStorageDomainMapDao().updateDiskProfileByImageGroupIdAndStorageDomainId(diskImage.getId(), Line 390: diskImage.getStorageIds().get(0), Line 391: diskImage.getDiskProfileId()); also set it to the disk so it'll reflect the current state. Line 392: } Line 393: } Line 394: } Line 395: http://gerrit.ovirt.org/#/c/29038/15/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileHelper.java: Line 30: return ValidationResult.VALID; Line 31: } Line 32: Line 33: Map<Guid, List<DiskProfile>> storageDiskProfilesMap = new HashMap<>(); Line 34: Map<DiskProfile, Guid> validDiskProfileForStorageDomainId = new HashMap<>(); you said that there gonna be changes here, didn't review this part yet Line 35: for (Entry<DiskImage, Guid> entry : map.entrySet()) { Line 36: DiskImage diskImage = entry.getKey(); Line 37: Guid storageDomainId = entry.getValue(); Line 38: DiskProfile diskProfile = null; -- To view, visit http://gerrit.ovirt.org/29038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7b6d977243cffc0bde772665ebaca47340075c6 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
