Martin Peřina has posted comments on this change. Change subject: core: Fix displaying result of VdsNotRespondingTreatment ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/31227/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVdsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVdsCommand.java: Line 87: @Override Line 88: public AuditLogType getAuditLogTypeValue() { Line 89: if (getSucceeded()) { Line 90: return AuditLogType.USER_VDS_STOP; Line 91: } else { > From the user point of view the action that failed was restarting the Host. Well, the problem is that the result of StopVdsCommand is displayed in Events tab, so user knows that it was executed as a part of RestartVdsCommand. So if we don't override the result, there will be shown either 'Host was stopped' or 'Failed to stop host' which are not correct at all. So if we show 'Host was not stopped due to fencing policy', it seems to me best way how to handle this. Line 92: return skippedDueToFencingPolicy ? Line 93: AuditLogType.VDS_NOT_STOPPED_DUE_TO_POLICY : Line 94: AuditLogType.USER_FAILED_VDS_STOP; Line 95: } -- To view, visit http://gerrit.ovirt.org/31227 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia864b986dd453920144ad1556c9f9d020da97c20 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
