Eli Mesika has posted comments on this change. Change subject: core: Fix displaying result of VdsNotRespondingTreatment ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/31227/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVdsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVdsCommand.java: Line 87: @Override Line 88: public AuditLogType getAuditLogTypeValue() { Line 89: if (getSucceeded()) { Line 90: return AuditLogType.USER_VDS_STOP; Line 91: } else { From the user point of view the action that failed was restarting the Host. That's true that we are implementing Restart as stop-wait-start-wait but this should be transparent to the user IMO and the log should say that the restart operation had failed I see that the log of the NonRespondingTreatmentCommand does exactly that so IMO this block should remain without any change : @Override public AuditLogType getAuditLogTypeValue() { return getSucceeded() ? AuditLogType.USER_VDS_STOP : AuditLogType.USER_FAILED_VDS_STOP; Line 92: return skippedDueToFencingPolicy ? Line 93: AuditLogType.VDS_NOT_STOPPED_DUE_TO_POLICY : Line 94: AuditLogType.USER_FAILED_VDS_STOP; Line 95: } http://gerrit.ovirt.org/#/c/31227/2/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties: Line 576: NETWORK_COMMINT_NETWORK_CHANGES_FAILED=Failed to commit network changes on ${VdsName} Line 577: SYSTEM_VDS_RESTART=Host ${VdsName} was restarted by the engine. Line 578: SYSTEM_FAILED_VDS_RESTART=A restart initiated by the engine to Host ${VdsName} has failed. Line 579: VDS_NOT_RESTARTED_DUE_TO_POLICY=Host ${VdsName} was not restarted due to fencing policy. Line 580: VDS_NOT_STOPPED_DUE_TO_POLICY=Host ${VdsName} was not stopped due to fencing policy. IMO redundant , see my prev comment on that Line 581: VDS_TIME_DRIFT_ALERT=Host ${VdsName} has time-drift of ${Actual} seconds while maximum configured value is ${Max} seconds. Line 582: PROXY_HOST_SELECTION=Host ${Proxy} from ${Origin} was chosen as a proxy to execute ${Command} command on Host ${VdsName}. Line 583: RECONSTRUCT_MASTER_FAILED_NO_MASTER=No valid Data Storage Domains are available in Data Center ${StoragePoolName} (please check your storage infrastructure). Line 584: RECONSTRUCT_MASTER_DONE=Reconstruct Master Domain for Data Center ${StoragePoolName} completed. -- To view, visit http://gerrit.ovirt.org/31227 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia864b986dd453920144ad1556c9f9d020da97c20 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches