Eli Mesika has posted comments on this change. Change subject: core: Display warning when fencing is disabled in cluster ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/31258/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java: Line 42: checkMaxMemoryOverCommitValue(); Line 43: getVdsGroup().setDetectEmulatedMachine(true); Line 44: DbFacade.getInstance().getVdsGroupDao().save(getVdsGroup()); Line 45: Line 46: if (!getVdsGroup().getFencingPolicy().isFencingEnabled()) { Define this block as a protected method in VdsGroupOperationCommandBase and call it from here Line 47: AuditLogableBase alb = new AuditLogableBase(); Line 48: alb.setVdsGroupId(getVdsGroup().getId()); Line 49: AuditLogDirector.log(alb, AuditLogType.FENCING_DISABLED_IN_CLUSTER_POLICY); Line 50: } http://gerrit.ovirt.org/#/c/31258/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java: Line 114: true, Line 115: true)); Line 116: } Line 117: Line 118: if (!getVdsGroup().getFencingPolicy().isFencingEnabled()) { Define this block as a protected method in VdsGroupOperationCommandBase and call it from here Line 119: AuditLogableBase alb = new AuditLogableBase(); Line 120: alb.setVdsGroupId(getParameters().getVdsGroup().getId()); Line 121: AuditLogDirector.log(alb, AuditLogType.FENCING_DISABLED_IN_CLUSTER_POLICY); Line 122: } http://gerrit.ovirt.org/#/c/31258/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java: Line 104: SYSTEM_FAILED_VDS_RESTART(122, AuditLogSeverity.ERROR, Line 105: AuditLogTimeInterval.MINUTE.getValue()), Line 106: VDS_NOT_RESTARTED_DUE_TO_POLICY(618), Line 107: VDS_FENCE_DISABLED_BY_CLUSTER_POLICY(620), Line 108: FENCING_DISABLED_IN_CLUSTER_POLICY(621, AuditLogSeverity.WARNING), Should be an ALERT such that it will appear in the ALERTS TAB in UI Line 109: Line 110: // Host time drift Alert Line 111: VDS_TIME_DRIFT_ALERT(604, AuditLogSeverity.WARNING, Line 112: AuditLogTimeInterval.MINUTE.getValue() * 60), -- To view, visit http://gerrit.ovirt.org/31258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4853b349571523fbb4dac54cae45d9d6a9df01f3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
