Eli Mesika has posted comments on this change. Change subject: core: Suppress VdsNotResponding execution if fencing is disabled ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/31257/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java: Line 76: return false; Line 77: } Line 78: } Line 79: return super.canDoAction(); Line 80: } > What about soft fencing? We would like it to run in case of an issue. Right, I think that the check should be in VdsEventListener code and logged as an ALERT that can be viewed from the ALERTS TAB Line 81: Line 82: /** Line 83: * Only fence the host if the VDS is down, otherwise it might have gone back up until this command was executed. If Line 84: * the VDS is not fenced then don't send an audit log event. http://gerrit.ovirt.org/#/c/31257/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java: Line 103: SYSTEM_VDS_RESTART(121, AuditLogTimeInterval.MINUTE.getValue()), Line 104: SYSTEM_FAILED_VDS_RESTART(122, AuditLogSeverity.ERROR, Line 105: AuditLogTimeInterval.MINUTE.getValue()), Line 106: VDS_NOT_RESTARTED_DUE_TO_POLICY(618), Line 107: VDS_FENCE_DISABLED_BY_CLUSTER_POLICY(620), I think that this should be an ALERT Line 108: Line 109: // Host time drift Alert Line 110: VDS_TIME_DRIFT_ALERT(604, AuditLogSeverity.WARNING, Line 111: AuditLogTimeInterval.MINUTE.getValue() * 60), http://gerrit.ovirt.org/#/c/31257/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java: Line 319: VDS_NO_VDS_PROXY_FOUND(ErrorType.CONFLICT), Line 320: VDS_FAILED_FENCE_VIA_PROXY_CONNECTION(ErrorType.CONFLICT), Line 321: VDS_FENCE_DISABLED_AT_SYSTEM_STARTUP_INTERVAL(ErrorType.CONFLICT), Line 322: VDS_FENCE_DISABLED_AT_QUIET_TIME(ErrorType.CONFLICT), Line 323: VDS_FENCE_DISABLED_BY_CLUSTER_POLICY(ErrorType.CONFLICT), > Why conflict? How would that be reflected in the log? Oved, Martin just followed previous code as you can see above this is how CONFLICT is documented : /** * Client made a request which is not applicable in the current status of the engine. The same request, under * different circumstances, would be applicable. For example, a client wants to start a VM which is already running. * In other circumstances (VM down) this request would be applicable. */ I think its OK Line 324: VDS_STATUS_NOT_VALID_FOR_UPDATE(ErrorType.CONFLICT), Line 325: VDS_EMPTY_NAME_OR_ID(ErrorType.BAD_PARAMETERS), Line 326: VDS_TRY_CREATE_WITH_EXISTING_PARAMS(ErrorType.BAD_PARAMETERS), Line 327: VDS_EMPTY_NAME(ErrorType.BAD_PARAMETERS), -- To view, visit http://gerrit.ovirt.org/31257 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I784564e41c89b4a95eff3377cd6545cf907ecdce Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
