Alona Kaplan has uploaded a new change for review.

Change subject: webadmin: Host->Interfaces, shorten column width
......................................................................

webadmin: Host->Interfaces, shorten column width

Change-Id: Iaeda10b5b93b9b0ebde4ec69c3e7f0de80228be9
Bug-Url: https://bugzilla.redhat.com/1115310
Signed-off-by: Alona Kaplan <alkap...@redhat.com>
---
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostInterfaceForm.java
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfacePanel.java
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/StatisticsPanel.java
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/VLanPanel.java
5 files changed, 24 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/91/31291/1

diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java
index 04121e0..e86fa92 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java
@@ -78,26 +78,26 @@
     void initTable(ApplicationConstants constants, ApplicationTemplates 
templates) {
         // Interface Panel
         table.addColumn(new EmptyColumn(), constants.empty(), "30px"); 
//$NON-NLS-1$
-        table.addColumn(new EmptyColumn(), constants.nameInterface(), 
"210px"); //$NON-NLS-1$
+        table.addColumn(new EmptyColumn(), constants.nameInterface(), 
"200px"); //$NON-NLS-1$
 
         // Bond Panel
-        table.addColumn(new EmptyColumn(), constants.bondInterface(), 
"210px"); //$NON-NLS-1$
+        table.addColumn(new EmptyColumn(), constants.bondInterface(), 
"200px"); //$NON-NLS-1$
 
         // Vlan Panel
-        table.addColumn(new EmptyColumn(), constants.vlanInterface(), 
"210px"); //$NON-NLS-1$
-        table.addColumn(new EmptyColumn(), constants.networkNameInterface(), 
"210px"); //$NON-NLS-1$
-        table.addColumn(new EmptyColumn(), constants.addressInterface(), 
"210px"); //$NON-NLS-1$
+        table.addColumn(new EmptyColumn(), constants.vlanInterface(), 
"200px"); //$NON-NLS-1$
+        table.addColumn(new EmptyColumn(), constants.networkNameInterface(), 
"200px"); //$NON-NLS-1$
+        table.addColumn(new EmptyColumn(), constants.addressInterface(), 
"120px"); //$NON-NLS-1$
 
         // Statistics Panel
-        table.addColumn(new EmptyColumn(), constants.macInterface(), "210px"); 
//$NON-NLS-1$
+        table.addColumn(new EmptyColumn(), constants.macInterface(), "120px"); 
//$NON-NLS-1$
         table.addColumnWithHtmlHeader(new EmptyColumn(), 
templates.sub(constants.speedInterface(), constants.mbps())
-                .asString(), "105px"); //$NON-NLS-1$
+                .asString(), "100px"); //$NON-NLS-1$
         table.addColumnWithHtmlHeader(new EmptyColumn(), 
templates.sub(constants.rxInterface(), constants.mbps())
-                .asString(), "105px"); //$NON-NLS-1$
+                .asString(), "100px"); //$NON-NLS-1$
         table.addColumnWithHtmlHeader(new EmptyColumn(), 
templates.sub(constants.txInterface(), constants.mbps())
-                .asString(), "105px"); //$NON-NLS-1$
+                .asString(), "100px"); //$NON-NLS-1$
         table.addColumnWithHtmlHeader(new EmptyColumn(), 
templates.sub(constants.dropsInterface(), constants.pkts())
-                .asString(), "105px"); //$NON-NLS-1$
+                .asString(), "100px"); //$NON-NLS-1$
 
         table.addActionButton(new 
WebAdminButtonDefinition<HostInterfaceLineModel>(constants.addEditInterface()) {
             @Override
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostInterfaceForm.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostInterfaceForm.java
index 7b05dd7..bdfdb00 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostInterfaceForm.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostInterfaceForm.java
@@ -26,10 +26,10 @@
     public HostInterfaceForm(final HostInterfaceListModel listModel) {
         isSelectionAvailable = listModel.getIsSelectionAvailable();
         grid = new Grid(1, 4);
-        grid.getColumnFormatter().setWidth(0, "240px"); //$NON-NLS-1$
-        grid.getColumnFormatter().setWidth(1, "210px"); //$NON-NLS-1$
-        grid.getColumnFormatter().setWidth(2, "630px"); //$NON-NLS-1$
-        grid.getColumnFormatter().setWidth(3, "630px"); //$NON-NLS-1$
+        grid.getColumnFormatter().setWidth(0, "230px"); //$NON-NLS-1$
+        grid.getColumnFormatter().setWidth(1, "200px"); //$NON-NLS-1$
+        grid.getColumnFormatter().setWidth(2, "520px"); //$NON-NLS-1$
+        grid.getColumnFormatter().setWidth(3, "520px"); //$NON-NLS-1$
         grid.setWidth("100%"); //$NON-NLS-1$
         grid.setHeight("100%"); //$NON-NLS-1$
         initWidget(grid);
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfacePanel.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfacePanel.java
index 9d0cb8a..c383421 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfacePanel.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfacePanel.java
@@ -49,7 +49,7 @@
         gridStyle.setBorderStyle(BorderStyle.SOLID);
 
         row.getColumnFormatter().setWidth(0, "30px"); //$NON-NLS-1$
-        row.getColumnFormatter().setWidth(1, "210px"); //$NON-NLS-1$
+        row.getColumnFormatter().setWidth(1, "200px"); //$NON-NLS-1$
 
         // Check box and interface status icon
         row.setWidget(0, 0, new HorizontalPanel() {
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/StatisticsPanel.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/StatisticsPanel.java
index 6bab089..4c66f34 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/StatisticsPanel.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/StatisticsPanel.java
@@ -42,15 +42,15 @@
         gridStyle.setBorderWidth(1, Unit.PX);
         gridStyle.setBorderStyle(BorderStyle.SOLID);
 
-        row.getColumnFormatter().setWidth(0, "210px"); //$NON-NLS-1$
-        row.getColumnFormatter().setWidth(1, "105px"); //$NON-NLS-1$
-        row.getColumnFormatter().setWidth(2, "105px"); //$NON-NLS-1$
-        row.getColumnFormatter().setWidth(3, "105px"); //$NON-NLS-1$
-        row.getColumnFormatter().setWidth(4, "105px"); //$NON-NLS-1$
+        row.getColumnFormatter().setWidth(0, "120px"); //$NON-NLS-1$
+        row.getColumnFormatter().setWidth(1, "100px"); //$NON-NLS-1$
+        row.getColumnFormatter().setWidth(2, "100px"); //$NON-NLS-1$
+        row.getColumnFormatter().setWidth(3, "100px"); //$NON-NLS-1$
+        row.getColumnFormatter().setWidth(4, "100px"); //$NON-NLS-1$
 
         // MAC
         LabelWithTextOverflow macLabel = new 
LabelWithTextOverflow(hostInterface.getMAC());
-        macLabel.setWidth("210px"); //$NON-NLS-1$
+        macLabel.setWidth("120px"); //$NON-NLS-1$
         row.setWidget(0, 0, macLabel);
 
         // Speed
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/VLanPanel.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/VLanPanel.java
index 0584332..b0c0cf2 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/VLanPanel.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/VLanPanel.java
@@ -19,9 +19,9 @@
 
 public class VLanPanel extends VerticalPanel {
 
-    public static final String CHECK_BOX_COLUMN_WIDTH = "210px"; //$NON-NLS-1$
-    public static final String NETWORK_NAME_COLUMN_WIDTH = "210px"; 
//$NON-NLS-1$
-    public static final String ADDRESS_COLUMN_WIDTH = "210px"; //$NON-NLS-1$
+    public static final String CHECK_BOX_COLUMN_WIDTH = "200px"; //$NON-NLS-1$
+    public static final String NETWORK_NAME_COLUMN_WIDTH = "200px"; 
//$NON-NLS-1$
+    public static final String ADDRESS_COLUMN_WIDTH = "120px"; //$NON-NLS-1$
 
     private final boolean isSelectionAvailable;
 


-- 
To view, visit http://gerrit.ovirt.org/31291
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaeda10b5b93b9b0ebde4ec69c3e7f0de80228be9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to