Lior Vernia has posted comments on this change. Change subject: webadmin: Host->Interfaces, shorten column width ......................................................................
Patch Set 2: (3 comments) In the bug mpavlik asks to divide some columns that aren't divided as they are part of the same panel. This patch doesn't address that. If you feel that this shouldn't be fixed, please add a UserExperience tag on the bug and ask the UX team to weigh in. http://gerrit.ovirt.org/#/c/31291/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java: Line 77: Line 78: void initTable(ApplicationConstants constants, ApplicationTemplates templates) { Line 79: // Interface Panel Line 80: table.addColumn(new EmptyColumn(), constants.empty(), "30px"); //$NON-NLS-1$ Line 81: table.addColumn(new EmptyColumn(), constants.nameInterface(), "200px"); //$NON-NLS-1$ mpavlik asked in the bug to make this consistent with other tabs. Shouldn't this be 100px, similar to SubTabNetworkHostView? Line 82: Line 83: // Bond Panel Line 84: table.addColumn(new EmptyColumn(), constants.bondInterface(), "200px"); //$NON-NLS-1$ Line 85: Line 80: table.addColumn(new EmptyColumn(), constants.empty(), "30px"); //$NON-NLS-1$ Line 81: table.addColumn(new EmptyColumn(), constants.nameInterface(), "200px"); //$NON-NLS-1$ Line 82: Line 83: // Bond Panel Line 84: table.addColumn(new EmptyColumn(), constants.bondInterface(), "200px"); //$NON-NLS-1$ Same here. Line 85: Line 86: // Vlan Panel Line 87: table.addColumn(new EmptyColumn(), constants.vlanInterface(), "200px"); //$NON-NLS-1$ Line 88: table.addColumn(new EmptyColumn(), constants.networkNameInterface(), "200px"); //$NON-NLS-1$ Line 83: // Bond Panel Line 84: table.addColumn(new EmptyColumn(), constants.bondInterface(), "200px"); //$NON-NLS-1$ Line 85: Line 86: // Vlan Panel Line 87: table.addColumn(new EmptyColumn(), constants.vlanInterface(), "200px"); //$NON-NLS-1$ Same here. Line 88: table.addColumn(new EmptyColumn(), constants.networkNameInterface(), "200px"); //$NON-NLS-1$ Line 89: table.addColumn(new EmptyColumn(), constants.addressInterface(), "120px"); //$NON-NLS-1$ Line 90: Line 91: // Statistics Panel -- To view, visit http://gerrit.ovirt.org/31291 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaeda10b5b93b9b0ebde4ec69c3e7f0de80228be9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
