Alon Bar-Lev has posted comments on this change. Change subject: build: use maven deploy and move jar handling to Makefile ......................................................................
Patch Set 1: Hi, I prefer the brew method of handling maven output, using the maven deploy to create maven repository of the artifacts. For my opinion this is healthier to do so and not to grab files out of the target directory at mid build. Also, the jar installation within the destination tree should be done by Makefile so it can be reused by other packagers. This patch modify the behaviour of the above two. I have not test this on live machine yet. Juan, You know the application far better than me... what are the implications of the NOTES? Maybe we should fix the maven build to produce the two missing packages and rename the root to parent. Is there anything you don't like in this patch? Thanks, Alon -- To view, visit http://gerrit.ovirt.org/6171 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9eb8b8f60f2be71b2054582b5e898ae996f324ac Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
