Allon Mureinik has posted comments on this change. Change subject: core: Forbid Bootable and Shareable Disks ......................................................................
Patch Set 2: Code-Review-1 (1 comment) See inline. http://gerrit.ovirt.org/#/c/31142/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskValidator.java: Line 132: Line 133: return ValidationResult.VALID; Line 134: } Line 135: Line 136: public ValidationResult isDiskShareableAndBootable() { This name is confusing - if a disk is infeef sharable and bootable, this will fail How about isBootLegal() ? Line 137: if (disk.isShareable() && disk.isBoot()) { Line 138: return new ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_DISK_CANNOT_BE_BOTH_SHAREABLE_AND_BOOTABLE); Line 139: } Line 140: return ValidationResult.VALID; -- To view, visit http://gerrit.ovirt.org/31142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e221d6534b71db96d0c58442220d249b305079b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
