Idan Shaby has posted comments on this change. Change subject: core: Forbid Bootable and Shareable Disks ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/31142/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java: Line 78: private SanStorageModel sanStorageModel; Line 79: private VolumeFormat volumeFormat; Line 80: private boolean previousWipeAfterDeleteEntity; Line 81: private boolean previousIsQuotaAvailable; Line 82: private boolean containsBootableDisk; > for readability, consider renaming to something like: 'isVmContainBootableD Done Line 83: Line 84: private SystemTreeItemModel systemTreeSelectedItem; Line 85: private String hash; Line 86: private UICommand cancelCommand; -- To view, visit http://gerrit.ovirt.org/31142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e221d6534b71db96d0c58442220d249b305079b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
