anmolbabu has posted comments on this change. Change subject: webadmin : Optimise for virt store on volumes ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/31041/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java: Line 490: getShowVolumeProfileDetailsCommand().setIsExecutionAllowed(allowProfileStatisticsDetails); Line 491: } Line 492: Line 493: private boolean getAllowOptimizeAvailability(GlusterVolumeEntity volume) { Line 494: if(volume.getReplicaCount() == 3) { > Shouldn't this be >= ? Not sure about this bcoz the link http://www.ovirt.org/Gluster_Storage_Domain_Reference says "use the gluster replica 3 (three copies)" . I'll confirm it from Aharon Canan - qa contact for the bug or Tal nisan - dev contact Line 495: return true; Line 496: } Line 497: return false; Line 498: } Line 843: list.add(new GlusterVolumeOptionParameters(getOption(volumeId, "group", optionGroupVirt)));//$NON-NLS-1$ Line 844: Line 845: list.add(new GlusterVolumeOptionParameters(getOption(volumeId, "storage.owner-uid", optionOwnerUserVirt)));//$NON-NLS-1$ Line 846: Line 847: list.add(new GlusterVolumeOptionParameters(getOption(volumeId, "storage.owner-gid", optionOwnerGroupVirt)));//$NON-NLS-1$ > Couldn't all of the above be part of getOptionsForOptimiseForVirtStore I initially thought of this but some how missed it.I'll change it.Thanks :) Line 848: Line 849: for(GlusterVolumeOptionEntity option : getOptionsForOptimiseForVirtStore(volumeId)) { Line 850: if(!isOptionEnabledOnVolume(volume, option)) { Line 851: list.add(new GlusterVolumeOptionParameters(option)); -- To view, visit http://gerrit.ovirt.org/31041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f995dec2258a3f5fc9673d5d075866b89f7773c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
