anmolbabu has posted comments on this change.

Change subject: webadmin : Optimise for virt store on volumes
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/31041/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java:

Line 892:                                                 
Frontend.getInstance().runMultipleAction(VdcActionType.SetGlusterVolumeOption, 
list);
Line 893:                                             }
Line 894:                                         }
Line 895:                                     };
Line 896:                                     
Frontend.getInstance().runQuery(VdcQueryType.GetGlusterVolumeById, new 
IdQueryParameters(volumeId), volumeQuery);
> This is not required. GlusterVolumeEntity will have all the option set on t
I am doing this I want to get all options available/enabled on a volume.Then, 
find if the required options are already enabled.If not enabled already, enable 
it now.But, the function only has set of selected volume ids as its called even 
when a new volume is being created.
Line 897:                                 }
Line 898:                             }
Line 899:                         };
Line 900: 


-- 
To view, visit http://gerrit.ovirt.org/31041
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f995dec2258a3f5fc9673d5d075866b89f7773c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to