Ravi Nori has uploaded a new change for review. Change subject: webadmin: 'Add Users and Groups' dialog the list should stretch to all page ......................................................................
webadmin: 'Add Users and Groups' dialog the list should stretch to all page The size of the search result should be increaed when the roles selection drop down is hidden Increase size from 70 to 80% leaving some room for error message panel at the bottom Change-Id: Ibe070e1116bbdda39c938724a82ce3642ed3dd8c Bug-Url: https://bugzilla.redhat.com/1126293 Signed-off-by: Ravi Nori <rn...@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.ui.xml 2 files changed, 18 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/43/31043/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java index da34c81..72a86bb 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java @@ -2,6 +2,7 @@ import java.util.ArrayList; +import com.google.gwt.resources.client.CssResource; import org.ovirt.engine.core.aaa.ProfileEntry; import org.ovirt.engine.core.common.businessentities.Role; import org.ovirt.engine.core.common.businessentities.aaa.DbUser; @@ -43,6 +44,14 @@ interface ViewUiBinder extends UiBinder<SimpleDialogPanel, AbstractPermissionsPopupView> { ViewUiBinder uiBinder = GWT.create(ViewUiBinder.class); } + + interface Style extends CssResource { + String searchItemsPanel(); + String searchItemsUserTabPanel(); + } + + @UiField + Style style; @UiField @WithElementId @@ -242,6 +251,7 @@ @Override public void hideRoleSelection(Boolean indic) { roleSelectionPanel.setVisible(!indic); + searchItemsScrollPanel.addStyleName(indic ? style.searchItemsUserTabPanel() : style.searchItemsPanel()); } @Override diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.ui.xml b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.ui.xml index c96ee0f..c6c1493 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.ui.xml +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.ui.xml @@ -6,7 +6,7 @@ <ui:with field='constants' type='org.ovirt.engine.ui.common.CommonApplicationConstants' /> - <ui:style> + <ui:style type="org.ovirt.engine.ui.common.view.popup.permissions.AbstractPermissionsPopupView.Style"> .mainLabel { font-weight: bold; padding: 5px; @@ -26,6 +26,13 @@ border-top: 1px solid #BBBBBB; } + .searchItemsUserTabPanel { + width: 100%; + height: 80%; + border-bottom: 1px solid #BBBBBB; + border-top: 1px solid #BBBBBB; + } + .searchStringEditor { width: 200px; height: 18px; -- To view, visit http://gerrit.ovirt.org/31043 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibe070e1116bbdda39c938724a82ce3642ed3dd8c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
