Ravi Nori has posted comments on this change. Change subject: webadmin: 'Add Users and Groups' dialog the list should stretch to all page ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/31043/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.ui.xml File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.ui.xml: Line 20: } Line 21: Line 22: .searchItemsPanel { Line 23: width: 100%; Line 24: height: 70%; > I think you can simply remove the height: 70%, and not do everything else. I tried removing the height completely, as stated in the email this makes the search items panel resize itself depending on the number of elements in the list 0 users - size is 0; 100 users - I need to scroll down to see the role selection dialog Line 25: border-bottom: 1px solid #BBBBBB; Line 26: border-top: 1px solid #BBBBBB; Line 27: } Line 28: -- To view, visit http://gerrit.ovirt.org/31043 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe070e1116bbdda39c938724a82ce3642ed3dd8c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
