Vered Volansky has posted comments on this change. Change subject: restapi: Fix NPE when live migrating a disk ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/30975/2/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java: Line 90: public Response move(Action action) { Line 91: validateParameters(action, "storageDomain.id|name"); Line 92: Guid storageDomainId = getStorageDomainId(action); Line 93: Disk disk = getDisk(); Line 94: Guid sourceStorageDomainId = getSourceStorageDomainId(disk); > I missed how this will solved the mentioned bug, can you elaborate? Source domain id was empty guid, resulting in NPE when trying to get the source domain according to this guid in LiveMigrateVmDisksCommand.validateSourceDomainsSpaceRequirements() Line 95: Guid imageId = asGuid(disk.getImageId()); Line 96: MoveDisksParameters params = Line 97: new MoveDisksParameters(Collections.singletonList(new MoveDiskParameters( Line 98: imageId, Line 104: protected Disk getDisk() { Line 105: return performGet(VdcQueryType.GetDiskByDiskId, new IdQueryParameters(guid)); Line 106: } Line 107: Line 108: protected Guid getSourceStorageDomainId(Disk disk) { > Have you verified that with LUN disk? seems like we'll get NPE now. Will check. Line 109: return asGuid(disk.getStorageDomains().getStorageDomains().get(0).getId()); Line 110: } Line 111: Line 112: @Override -- To view, visit http://gerrit.ovirt.org/30975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I570a4c81605b63a860c012e9071e46c34c793635 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
