Liron Aravot has posted comments on this change. Change subject: restapi: Fix NPE when live migrating a disk ......................................................................
Patch Set 2: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/30975/2/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java: Line 90: public Response move(Action action) { Line 91: validateParameters(action, "storageDomain.id|name"); Line 92: Guid storageDomainId = getStorageDomainId(action); Line 93: Disk disk = getDisk(); Line 94: Guid sourceStorageDomainId = getSourceStorageDomainId(disk); I missed how this will solved the mentioned bug, can you elaborate? Line 95: Guid imageId = asGuid(disk.getImageId()); Line 96: MoveDisksParameters params = Line 97: new MoveDisksParameters(Collections.singletonList(new MoveDiskParameters( Line 98: imageId, Line 104: protected Disk getDisk() { Line 105: return performGet(VdcQueryType.GetDiskByDiskId, new IdQueryParameters(guid)); Line 106: } Line 107: Line 108: protected Guid getSourceStorageDomainId(Disk disk) { Have you verified that with LUN disk? seems like we'll get NPE now. Line 109: return asGuid(disk.getStorageDomains().getStorageDomains().get(0).getId()); Line 110: } Line 111: Line 112: @Override -- To view, visit http://gerrit.ovirt.org/30975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I570a4c81605b63a860c012e9071e46c34c793635 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
