Allon Mureinik has posted comments on this change. Change subject: core: db sqush 3.2 upgrade scripts ......................................................................
Patch Set 3: Code-Review+2 (1 comment) wrt to my previous comments: - Don't quite know how, but I missed the additions to insert_predefined_roles. After seeing this I no longer suspect a bug here, and withdraw my -1. My bad. - I see your point about formatting changes. Accepted. http://gerrit.ovirt.org/#/c/30899/3//COMMIT_MSG Commit Message: Line 10: creation scripts. Line 11: Line 12: 1) Creating a git branch and removing all upgrade scripts except Line 13: those with 03_02_* Line 14: 2) Creating a new 3_2 database based on 1) You have a redundant space here - please remove when you rebase. Line 15: 3) Using pg_dump to export 3_2 schema & data Line 16: 4) Replacing the create_tables.sql with the schema file generated on 3) Line 17: 5) Editing manually insert_data.sql and insert_predefined_roles.sql Line 18: to have all changes from data exported at step 3) -- To view, visit http://gerrit.ovirt.org/30899 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ce390403c6133b66726089ff3b1e0c91ec4a2c8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
