Eli Mesika has posted comments on this change. Change subject: core: db sqush 3.2 upgrade scripts ......................................................................
Patch Set 2: (5 comments) http://gerrit.ovirt.org/#/c/30899/2//COMMIT_MSG Commit Message: Line 19: 6) Creating a database engine_db_squash_3_2 on this patch branch Line 20: 7) Creating a database engine_master on the master branch Line 21: 8) Use pg_dump to export db from step 6) schema & data Line 22: 9) Use pg_dump to export db from step 7) schema & data Line 23: 10)Compare schema & data from steps 8) & 9) > Missing space after "10)" will fix Line 24: Line 25: Change-Id: I1ce390403c6133b66726089ff3b1e0c91ec4a2c8 http://gerrit.ovirt.org/#/c/30899/2/packaging/dbscripts/common_sp.sql File packaging/dbscripts/common_sp.sql: Line 510: dc_id uuid, Line 511: dc_name character varying, Line 512: spm_host_id uuid, Line 513: spm_host_name character varying, Line 514: task_count integer > There doesn't seem to be anything here except for a format change - I would I am generating this format from pg_dump. As I want to minimize manual modifications, I had copied the generated code and replaced it with the existing one. This will help me in future to do the same and replace the existing code with the generated one. I believe that this is much more safe than a manual change Line 515: ); Line 516: Line 517: Line 518: create or replace FUNCTION fn_db_get_async_tasks() http://gerrit.ovirt.org/#/c/30899/2/packaging/dbscripts/create_functions.sql File packaging/dbscripts/create_functions.sql: Line 728: storage_id uuid, Line 729: storage_name character varying(250), Line 730: storage_size_gb bigint, Line 731: storage_size_gb_usage double precision Line 732: ); > This file too - I'd discard the format changes I am generating this format from pg_dump. As I want to minimize manual modifications, I had copied the generated code and replaced it with the existing one. This will help me in future to do the same and replace the existing code with the generated one. I believe that this is much more safe than a manual change Line 733: Line 734: CREATE OR REPLACE FUNCTION calculateAllStorageUsage() Line 735: RETURNS SETOF all_storage_usage_rs STABLE Line 736: AS $function$ http://gerrit.ovirt.org/#/c/30899/2/packaging/dbscripts/upgrade/03_02_0240_add_gluster_action_version_map.sql File packaging/dbscripts/upgrade/03_02_0240_add_gluster_action_version_map.sql: Line 47 Line 48 Line 49 Line 50 Line 51 > Where are these? I cannot find them in the new scripts. See insert_predefined_roles.sql : -- Set gluster volume option insert into action_version_map (action_type, cluster_minimal_version, storage_pool_minimal_version) values(v_SET_GLUSTER_VOLUME, '3.1', '*'); -- Start gluster volume insert into action_version_map (action_type, cluster_minimal_version, storage_pool_minimal_version) values(v_START_GLUSTER_VOLUME, '3.1', '*'); -- Stop gluster volume insert into action_version_map (action_type, cluster_minimal_version, storage_pool_minimal_version) values(v_STOP_GLUSTER_VOLUME, '3.1', '*'); -- Reset gluster volume options insert into action_version_map (action_type, cluster_minimal_version, storage_pool_minimal_version) values(v_RESET_GLUSTER_VOLUME, '3.1', '*'); -- Delete gluster volume insert into action_version_map (action_type, cluster_minimal_version, storage_pool_minimal_version) values(v_DELETE_GLUSTER_VOLUME_BRICKS, '3.1', '*'); -- Gluster volume remove bricks insert into action_version_map (action_type, cluster_minimal_version, storage_pool_minimal_version) values(v_REMOVE_GLUTER_VOLUME_BRICKS, '3.1', '*'); -- Start gluster volume rebalance insert into action_version_map (action_type, cluster_minimal_version, storage_pool_minimal_version) values(v_REBALANCE_GLUSTER_VOLUME, '3.1', '*'); -- Replace gluster volume bricks insert into action_version_map (action_type, cluster_minimal_version, storage_pool_minimal_version) values(v_REPLACE_GLUSTER_VOLUME_BRICKS, '3.1', '*'); -- Add bricks to Gluster volume insert into action_version_map (action_type, cluster_minimal_version, storage_pool_minimal_version) values(v_ADD_GLUSTER_VOLUME_BRICKS, '3.1', '*'); -- Start Gluster volume profile insert into action_version_map (action_type, cluster_minimal_version, storage_pool_minimal_version) values(v_START_GLUSTER_VOLUME_PROFILE, '3.2', '*'); -- Stop gluster volume profile insert into action_version_map (action_type, cluster_minimal_version, storage_pool_minimal_version) values(v_STOP_LUSTER_VOLUME_PROFILE, '3.2', '*'); -- Remove gluster server insert into action_version_map (action_type, cluster_minimal_version, storage_pool_minimal_version) values(v_REMOVE_GLUSTER_SERVER, '3.2', '*'); http://gerrit.ovirt.org/#/c/30899/2/packaging/dbscripts/upgrade/03_02_0470_lsm_version_support.sql File packaging/dbscripts/upgrade/03_02_0470_lsm_version_support.sql: Line 1 Line 2 > Where are these inserts in the new scripts? See: insert_predefined_roles.sql -- lsm_version_support insert into action_version_map values (v_LIVE_MIGRATE_DISK, '3.2', '3.2'); insert into action_version_map values (v_LIVE_MIGRATE_DISKS, '3.2', '3.2'); -- To view, visit http://gerrit.ovirt.org/30899 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ce390403c6133b66726089ff3b1e0c91ec4a2c8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
