Allon Mureinik has uploaded a new change for review.
Change subject: core: isStorageFormatSupportedByStoragePool
......................................................................
core: isStorageFormatSupportedByStoragePool
Simplified the boolean expression in
AddStorageDomainCommand#isStorageFormatSupportedByStoragePool() for
better readability.
Change-Id: I59a9aa5ec041da4b9930a534c5c2fc23cb542767
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
1 file changed, 1 insertion(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/52/30952/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
index d5d1d76..cd97158 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
@@ -176,11 +176,8 @@
Set<StorageFormatType> supportedStorageFormats =
getSupportedStorageFormatSet(targetStoragePool.getcompatibility_version());
- if (!supportedStorageFormats.contains(storageFormat)) {
- return false;
- }
+ return supportedStorageFormats.contains(storageFormat);
- return true;
}
private boolean isStorageFormatCompatibleWithDomain() {
--
To view, visit http://gerrit.ovirt.org/30952
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I59a9aa5ec041da4b9930a534c5c2fc23cb542767
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
