Allon Mureinik has uploaded a new change for review. Change subject: core: AddStorageDomainCommand use of HashMap ......................................................................
core: AddStorageDomainCommand use of HashMap Weaken HashMap declarations to Maps wherever possible. Change-Id: Ifcbecd38ef12b6f42c99c55a79dc6c3eb39886fb Signed-off-by: Allon Mureinik <amure...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/57/30957/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java index 1e005a1..b5660f0 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java @@ -4,8 +4,8 @@ import java.util.ArrayList; import java.util.Collections; -import java.util.HashMap; import java.util.List; +import java.util.Map; import java.util.Set; import org.ovirt.engine.core.bll.utils.PermissionSubject; @@ -113,7 +113,7 @@ protected Pair<Boolean, Integer> connectStorage() { String connectionId = getStorageDomain().getStorage(); StorageServerConnections connection = getStorageServerConnectionDAO().get(connectionId); - HashMap<String, String> result = (HashMap<String, String>) runVdsCommand( + Map<String, String> result = (Map<String, String>) runVdsCommand( VDSCommandType.ConnectStorageServer, new StorageServerConnectionManagementVDSParameters(getParameters().getVdsId(), Guid.Empty, connection.getstorage_type(), -- To view, visit http://gerrit.ovirt.org/30957 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifcbecd38ef12b6f42c99c55a79dc6c3eb39886fb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches