David Caro has posted comments on this change. Change subject: jobs: ovirt-hosted-engine-setup ......................................................................
Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/30510/8/jobs/confs/shell-scripts/build_mock_srcrpm.sh File jobs/confs/shell-scripts/build_mock_srcrpm.sh: Line 67: --base="$distribution-$arch.cfg" \ Line 68: --option="basedir=$WORKSPACE/mock/" \ Line 69: $mock_repos \ Line 70: > "$mock_conf.cfg" Line 71: sudo touch /var/cache/mock/*/root_cache/cache.tar.gz || : > Not sure, I took it from an existing script in this directory. Yes, it does. This is because mock uses the time of the config file as reference to know if the cache is outdated, and as we always create the config file, I preferred using the cache all the time to not use it at all (as the packages will be updated anyhow). Line 72: cat "$mock_conf.cfg" Line 73: popd Line 74: Line 75: ## prepare the command line Line 149: "${{rpmbuild_options[@]}}" \ Line 150: -ts *.gz Line 151: Line 152: Line 153: mkdir /tmp/SRCRPMS > this is executed inside the chroot, how do you pass it back to the calling No need, as it's created inside the chroot, you are sure it will not exist, it will not collide and it will be deleted after. The benefits of having a clean env on each run, you don't care what trash you leave behind (if you don't have to) Line 154: mv *.tar.gz /tmp/SRCRPMS/ Line 155: mv *src.rpm /tmp/SRCRPMS/ Line 156: EOF Line 157: -- To view, visit http://gerrit.ovirt.org/30510 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10a908a2be067d38616c41a2c2e6cb3effc9c787 Gerrit-PatchSet: 8 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ew...@kohlvanwijngaarden.nl> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Ohad Basan <oba...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
