Alon Bar-Lev has posted comments on this change.

Change subject: engine, webadmin: Webadmin read reports.xml from remote reports 
app
......................................................................


Patch Set 21:

(1 comment)

http://gerrit.ovirt.org/#/c/29723/21/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetRedirectServletReportsPageQuery.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetRedirectServletReportsPageQuery.java:

> The front end needs to know the base url to be used for reports web app.
can we have this all using redirect servlet at the engine side, instead of 
having the client to know what the url is?
Line 1: package org.ovirt.engine.core.bll;
Line 2: 
Line 3: import org.ovirt.engine.core.common.queries.VdcQueryParametersBase;
Line 4: import org.ovirt.engine.core.utils.EngineLocalConfig;


-- 
To view, visit http://gerrit.ovirt.org/29723
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76db7ab889f21de083bb3c8276e8abb77b68fdb3
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Shirly Radco <sra...@redhat.com>
Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to