Ravi Nori has posted comments on this change. Change subject: engine, webadmin: Webadmin read reports.xml from remote reports app ......................................................................
Patch Set 19: (2 comments) http://gerrit.ovirt.org/#/c/29723/19/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ReportInit.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ReportInit.java: Line 28: private static final ReportInit INSTANCE = new ReportInit(); Line 29: private static final int MAX_RETRY_COUNTS = 20; Line 30: private static final int RETRY_INTERVAL = 30000; Line 31: public static final String ReportStatusService = "services/reports-servlet?command=status"; //$NON-NLS-1$ Line 32: public static final String ReportXmlService = "services/reports-servlet?command=xml"; //$NON-NLS-1$ > command=webadmin-ui-xml? changed to command=webadmin-ui-xml Leaving out version for now, if that is okay Line 33: private int retryCount; Line 34: private boolean reportsWebappDeployed; Line 35: private boolean scheduledStatusCheckInProgress; Line 36: private boolean reportsEnabled; http://gerrit.ovirt.org/#/c/29723/19/packaging/services/ovirt-engine/ovirt-engine.conf.in File packaging/services/ovirt-engine/ovirt-engine.conf.in: Line 214: # Reports Line 215: # by default serv 404. Line 216: # Line 217: ENGINE_REPORTS_BASE_URL=/ovirt-engine-reports Line 218: ENGINE_REPORTS_SERVLET_URL=${ENGINE_REPORTS_BASE_URL}/ReportsServlet > this must be full url... no? default: Changed default to empty, the engine-setup needs to be modified to write the url to this file Line 219: ENGINE_REPORTS_UI=${ENGINE_VAR}/reports.xml Line 220: Line 221: -- To view, visit http://gerrit.ovirt.org/29723 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76db7ab889f21de083bb3c8276e8abb77b68fdb3 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
